Fix bug with too-long substrings #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
approved these changes
Oct 17, 2024
rmunn
added a commit
to sillsdev/web-languageforge
that referenced
this pull request
Oct 18, 2024
This pulls in the bugfix for the CommentConversionError class from sillsdev/LfMerge#350.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assumed that
string.Substring(0, 100)was safe and that on a string of less than 100 characters it would just return the unmodified string. That would be the sensible thing to do — but the C# API loves to throw exceptions instead of doing the sensible thing. So we need to check the length ourselves before callingstring.Substring.