Add fmt::Display implementation for MessageClass
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a strong negative opinion about this PR, but could you clarify the motivation behind it? |
I am using the textual representation for metrics that I am recording about in and out-going messages and figured it would be handy to have them upstream! |
|
I see. Thank you for explaining! |
github-merge-queue bot
pushed a commit
to firezone/firezone
that referenced
this pull request
Sep 21, 2023
I've opened several PRs upstream for code that was missing in `stun-codec` for our purposes. Those have been accepted and released, so we can bump to that version now and remove that code. Related: sile/stun_codec#14. Related: sile/stun_codec#15. Related: sile/stun_codec#16. Related: sile/stun_codec#17. A big thanks to @sile for the crate and being responsive maintainer :partying_face:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.