Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(math): Avoid page breaks before display math equations #2162

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Omikhleia
Copy link
Member

See #2160.
This is a conservative workaround.
Introducing the predisplay/postdisplay penalties is the right thing to do, but a more general solution to the full issue requires a more subtle handling of in-paragraph display math equations, which is not considered here.

@Omikhleia Omikhleia added the bug Software bug issue label Nov 9, 2024
@Omikhleia Omikhleia self-assigned this Nov 9, 2024
@Omikhleia Omikhleia requested a review from a team as a code owner November 9, 2024 15:34
@alerque
Copy link
Member

alerque commented Nov 9, 2024

v0.15.6 is a bit delayed, I'm chasing an unexpected panic in some builds and some build concerns. At first blush this seems to make sense to me but I don't have time to dig into alternatives. If you think this should go out in the current batch of math fixes and features please feel free to target the milestone and I'll review before releasing.

@Omikhleia Omikhleia added this to the v0.15.6 milestone Nov 9, 2024
@Omikhleia
Copy link
Member Author

Omikhleia commented Nov 9, 2024

If you think this should go out in the current batch of math fixes and features please feel free to target the milestone and I'll review before releasing.

Yes, it's still better than nothing here -- so adding the 0.15.6 milestone if it's still doable.
I commented the original issue for the "eventual" right way to fix this properly at some point, but I might never reach that point any time soon, while at least here we can have something fairly decent working with the current implementation, without taking too much risks.
More generally, I'm nearly done with what I wanted in the "first" batch of mathematical "fixes & improvements":

  • I see you moved Math font size does not follow the current normal text size #2145 to 0.15.7 and I agree we need to better address it (for now, I can go for the workaround in my math booklet in progress, and re-consider this point later)
  • I'm working on the "operator table" from MathML, but it's a "big" thing to get right... It's on tracks, but I can't say when I'll complete it (this week? next one? later? doh!)
  • And the next topic would be a proper handling of (at least top) accents and (horizontal) stretchy operators, not a big thing but it's highly depending on the previous point.

So I'm still adding stuff to it, but feel safe to "cut the release" at your convenience :)

See sile-typesetter#2160.
This is a conservative workaround.
Introducing the predisplay/postdisplay penalties is the right thing to
do, but a more general solution to the full issue requires a more subtle
handling of in-paragraph display math equations, which is not considered
here.
@alerque alerque merged commit 8128df3 into sile-typesetter:master Nov 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software bug issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants