Improve mergify config #6852
Merged
Improve mergify config #6852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
requested review from
michaelsproul and
jimmygchen
and removed request for
michaelsproul
jimmygchen
reviewed
Jan 23, 2025
.github/mergify.yml
Outdated
| @@ -18,6 +18,7 @@ pull_request_rules: | |||
| - base=unstable | |||
| - label=trivial | |||
| - author=@sigp/lighthouse | |||
| - conflict | |||
There was a problem hiding this comment.
should this be conflict=false?
There was a problem hiding this comment.
Hi Jimmy, thanks for noticing it forgot to update, = false doesn't work for boolean types:
Operators are invalid for Boolean attribute: conflict``
I used the - operator to negate it, see here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
And partially address #6845
ready-for-mergelabel instead ofready-to-mergetrivialPRs if thetriviallabel is removed.trivialPRs that have conflicts.the missing one seems impossible as I didn't find a condition for a removed label.