Fork aware max values in rpc #6847
Open
+203
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
commented
Jan 23, 2025
| @@ -455,7 +459,6 @@ impl<T: BeaconChainTypes> SyncNetworkContext<T> { | |||
| (None, None) | |||
| }; | |||
|
|
|||
| // TODO(pawan): this would break if a batch contains multiple epochs | |||
There was a problem hiding this comment.
Even if a batch contains multiple epochs (which it doesn't), this is a very niche case that would only break during fork boundaries.
jxs
approved these changes
Jan 24, 2025
| @@ -258,10 +260,11 @@ pub fn spawn<T: BeaconChainTypes>( | |||
| network_send: mpsc::UnboundedSender<NetworkMessage<T::EthSpec>>, | |||
| beacon_processor: Arc<NetworkBeaconProcessor<T>>, | |||
| sync_recv: mpsc::UnboundedReceiver<SyncMessage<T::EthSpec>>, | |||
| fork_context: Arc<ForkContext>, | |||
There was a problem hiding this comment.
nit: we can just pass the ForkName which is Copy and avoid clonning the Arc when passing it
There was a problem hiding this comment.
current_fork can change during runtime so we may use the outdated value if we do that . its just an Arc clone so it's okay imo
There was a problem hiding this comment.
makes sense, thanks for explaining Pawan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
In #6329 we changed
max_blobs_per_blockfrom a preset to a config value.We weren't using the right value based on fork in that PR. This is a follow up PR to use the fork dependent values.
In the proces, I also updated other places where we weren't using fork dependent values from the ChainSpec.
Note to reviewer: easier to go through by commit