add basic peer manager #108
Conversation
diegomrsantos
force-pushed
the
peer-manager
branch
from
bddd5f5 to
e04e07a
Compare
diegomrsantos
force-pushed
the
peer-manager
branch
3 times, most recently
from
01ebfd7 to
d0970c4
Compare
diegomrsantos
force-pushed
the
peer-manager
branch
from
d0970c4 to
80d0178
Compare
| self.outbound_ping_peers.insert(peer_id); | ||
| self.events.push(PeerManagerEvent::Ping(peer_id)); |
There was a problem hiding this comment.
@AgeManning do you know why we need this? I thought it was handled by libp2p's Ping.
diegomrsantos
requested review from
dknopik,
AgeManning and
jking-aus
and removed request for
dknopik and
AgeManning
| @@ -85,6 +85,7 @@ parking_lot = "0.12" | |||
| reqwest = "0.12.12" | |||
| rusqlite = "0.28.0" | |||
| serde = { version = "1.0.208", features = ["derive"] } | |||
| smallvec = "2.0.0-alpha.9" | |||
There was a problem hiding this comment.
Any specific reason why 2.0.0-alpha.9? Unless we need it, I suggest we stay with the most recent one from 1.*.
There was a problem hiding this comment.
There's no reason, I just chose the latest one.
| // Updates peer's scores and unban any peers if required. | ||
| //let actions = self.peers.write().update_scores(); | ||
| //for (peer_id, action) in actions { | ||
| // self.handle_score_action(&peer_id, action, None); | ||
| //} | ||
|
|
||
| // Update peer score metrics; | ||
| //self.update_peer_score_metrics(); | ||
|
|
||
| // Prune any excess peers back to our target in such a way that incentivises good scores and | ||
| // a uniform distribution of subnets. | ||
| //self.prune_excess_peers(); | ||
|
|
||
| // Unban any peers that have served their temporary ban timeout | ||
| //self.unban_temporary_banned_peers(); |
There was a problem hiding this comment.
What's the plan for the commented calls here?
There was a problem hiding this comment.
We'll need it eventually, but it's not important for now. The plan is to reuse the LH code anyway.
| /// A lighthouse node (the best kind). | ||
| Lighthouse, | ||
| /// A Nimbus node. | ||
| Nimbus, | ||
| /// A Teku node. | ||
| Teku, | ||
| /// A Prysm node. | ||
| Prysm, | ||
| /// A lodestar node. | ||
| Lodestar, | ||
| /// A Caplin node. | ||
| Caplin, |
There was a problem hiding this comment.
Need to update this to Anchor and GoSsv
There was a problem hiding this comment.
I think this isn't important for now. Wdyt?
| /// The current syncing state of the peer. The state may be determined after it's initial | ||
| /// connection. | ||
| sync_status: SyncStatus, |
There was a problem hiding this comment.
SSV has no sync status communicated via network, right?
There was a problem hiding this comment.
I don't know, we need input here. But I'd say it's not important for now.
Issue Addressed
Related to #18
Proposed Changes
Dependencies:
Updated Cargo.toml and anchor/network/Cargo.toml to include new dependencies such as smallvec, arbitrary, delay_map, and itertools.
Network Types:
Added peer_manager module to anchor/network/src/lib.rs.
Network Implementation:
Enhanced anchor/network/src/behaviour.rs and anchor/network/src/network.rs to integrate the PeerManager.
The PeerManager is responsible for managing peer connections, including dialing, connecting, and disconnecting peers.
It includes logic to maintain the target peer count, ensuring the network has the desired number of peers connected.
Peer Manager:
Added a new peer_manager directory with modules for managing peers.
Implemented functionality in PeerManager to handle peer connections, maintain the target peer count, and manage peer discovery.
Additional Info
For now, it's mostly a copy from LH with a few modifications. However, there are efforts to make the LH code more modular, generic, and thus easier to reuse. See sigp/lighthouse#6840 and sigp/lighthouse#6757