Embedded invite updates #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| class EntityManager implements EntityManagerInterface | ||
| { | ||
| private const CLIENT = 'SN_PHP_SDK'; |
There was a problem hiding this comment.
CLIENT_NAME OR SN_CLIENT as option
| use SignNow\Api\Entity\DocumentGroup\GroupInvite\InviteStep; | ||
| use SignNow\Api\Entity\DocumentGroup\GroupInvite\Reminder; | ||
| use SignNow\Rest\EntityManager; | ||
| use SignNow\Api\Service\EntityManager\EntityManager; |
There was a problem hiding this comment.
One more unused import
| use SignNow\Api\Entity\DocumentGroup\GroupInvite\InviteStep; | ||
| use SignNow\Api\Entity\DocumentGroup\GroupInvite\Reminder; | ||
| use SignNow\Rest\EntityManager; | ||
| use SignNow\Api\Service\EntityManager\EntityManager; |
There was a problem hiding this comment.
One more unused import
| return $this; | ||
| } | ||
|
|
||
| public function getClientName(): ?string |
There was a problem hiding this comment.
$this->clientName can't be null, because in the constructor you have $this->clientName = $clientName ?? self::CLIENT
| */ | ||
| private function makeHeaders(array $headers): array | ||
| { | ||
| if ($this->getClientName() === null) { |
There was a problem hiding this comment.
You may drop it if clientName cant be empty
Vasyl-Kravets
approved these changes
Dec 12, 2023
| * | ||
| * @return InviteRequest | ||
| */ | ||
| public function setDeclineRedirectUri(?string $declineRedirectUri): InviteRequest |
There was a problem hiding this comment.
What for we are allowing to send null as an attribute?
There was a problem hiding this comment.
It's not required attribute
so it can be nullable
and someone could remove it from sending request
PetrVakulenko
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.