[SNAPI-10272, SNAPI-11508] Add error handler.

signnow · May 11, 2022 · e6d2986 · e6d2986
1 parent c54a378
commit e6d2986
Show file tree

Hide file tree

Showing 3 changed files with 87 additions and 16 deletions.
diff --git a/src/Service/Request/Handler/DefaultErrorHandler.php b/src/Service/Request/Handler/DefaultErrorHandler.php
@@ -0,0 +1,30 @@
+<?php
+declare(strict_types = 1);
+
+namespace SignNow\Rest\Service\Request\Handler;
+
+use Exception;
+use GuzzleHttp\Exception\RequestException;
+use SignNow\Rest\Entity\Error;
+
+/**
+ * Class DefaultErrorHandler
+ *
+ * @package SignNow\Rest\Service\Request\Handler
+ */
+class DefaultErrorHandler implements ErrorHandlerInterface
+{
+    /**
+     * @param Exception $exception
+     *
+     * @return Error
+     */
+    public function handle(Exception $exception): Error
+    {
+        $error = new Error();
+        $error->setResponse(($exception instanceof RequestException) ? $exception->getResponse() : null);
+        $error->setMessage($exception->getMessage());
+
+        return $error;
+    }
+}
diff --git a/src/Service/Request/Handler/ErrorHandlerInterface.php b/src/Service/Request/Handler/ErrorHandlerInterface.php
@@ -0,0 +1,22 @@
+<?php
+declare(strict_types = 1);
+
+namespace SignNow\Rest\Service\Request\Handler;
+
+use Exception;
+use SignNow\Rest\Entity\Error;
+
+/**
+ * Interface ErrorHandlerInterface
+ *
+ * @package SignNow\Rest\Service\Request\Handler
+ */
+interface ErrorHandlerInterface
+{
+    /**
+     * @param Exception $exception
+     *
+     * @return Error
+     */
+    public function handle(Exception $exception): Error;
+}
diff --git a/src/Service/Request/Pool.php b/src/Service/Request/Pool.php
@@ -5,12 +5,12 @@
 
 use Exception;
 use GuzzleHttp\ClientInterface;
-use GuzzleHttp\Exception\RequestException;
 use GuzzleHttp\Psr7\Response;
 use LogicException;
 use SignNow\Rest\Entity\Collection\Errors;
-use SignNow\Rest\Entity\Error;
 use SignNow\Rest\EntityManager\Exception\PoolException;
+use SignNow\Rest\Service\Request\Handler\DefaultErrorHandler;
+use SignNow\Rest\Service\Request\Handler\ErrorHandlerInterface;
 use SignNow\Rest\Service\Request\Pool\Item;
 
 /**
@@ -25,6 +25,11 @@ class Pool implements PoolInterface
      */
     protected $client;
 
+    /**
+     * @var ErrorHandlerInterface
+     */
+    private $errorHandler;
+
     /**
      * @var Item[]
      */
@@ -39,10 +44,12 @@ class Pool implements PoolInterface
      * Pool constructor.
      *
      * @param ClientInterface $client
+     * @param ErrorHandlerInterface|null $errorHandler
      */
-    public function __construct(ClientInterface $client)
+    public function __construct(ClientInterface $client, ?ErrorHandlerInterface $errorHandler = null)
     {
         $this->client = $client;
+        $this->errorHandler = $errorHandler ?: new DefaultErrorHandler();
         $this->errors = new Errors();
     }
 
@@ -63,19 +70,8 @@ public function send(int $concurrencyLimit = null): PoolInterface
         }, $this->items);
 
         $options = [
-            'fulfilled' => function (Response $response, $index) {
-                $this->items[$index]->setResponse($response);
-            },
-            'rejected' => function (Exception $reason, $index, $promise) {
-                $error = new Error();
-                $response = ($reason instanceof RequestException) ? $reason->getResponse() : null;
-
-                $error->setResponse($response);
-                $error->setMessage($reason->getMessage());
-                $this->errors->push((int)$index, $error);
-
-                $this->items[$index]->setError($this->errors->getError($index));
-            },
+            'fulfilled' => $this->onFulfilled(),
+            'rejected' => $this->onRejected(),
         ];
 
         if ($concurrencyLimit) {
@@ -144,4 +140,27 @@ public function getErrors(): Errors
     {
         return $this->errors;
     }
+
+    /**
+     * @return callable
+     */
+    protected function onFulfilled(): callable
+    {
+        return function (Response $response, $index) {
+            $this->items[$index]->setResponse($response);
+        };
+    }
+
+    /**
+     * @return callable
+     */
+    protected function onRejected(): callable
+    {
+        return function (Exception $reason, $index, $promise) {
+            $error = $this->errorHandler->handle($reason);
+
+            $this->errors->push((int)$index, $error);
+            $this->items[$index]->setError($error);
+        };
+    }
 }