fix: Prevent crash from recursive calls to setState. (#306)

In some instances setState calls updateSuggestionsPosition which calls setState which calls updateSuggestionsPosition... until it crashes.
signavio · Feb 21, 2019 · a93665a · a93665a
1 parent c7043f5
commit a93665a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/MentionsInput.js b/src/MentionsInput.js
@@ -566,8 +566,12 @@ class MentionsInput extends React.Component {
     this.updateSuggestionsPosition()
   }
 
-  componentDidUpdate(prevProps) {
-    this.updateSuggestionsPosition()
+  componentDidUpdate(prevProps, prevState) {
+    // Update position of suggestions unless this componentDidUpdate was
+    // triggered by an update to suggestionsPosition.
+    if (prevState.suggestionsPosition === this.state.suggestionsPosition) {
+      this.updateSuggestionsPosition()
+    }
 
     // maintain selection in case a mention is added/removed causing
     // the cursor to jump to the end