Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envoy metrics discovery bundle #5780

Merged
merged 11 commits into from
Jan 12, 2025
Merged

Add envoy metrics discovery bundle #5780

merged 11 commits into from
Jan 12, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jan 11, 2025

Description:
Adds a new discovery bundle targeting envoy proxy metrics.

@atoulme atoulme requested review from a team as code owners January 11, 2025 00:50
@atoulme
Copy link
Contributor Author

atoulme commented Jan 11, 2025

I tested this locally. It worked well enough on my machine.

@jinja2
Copy link
Contributor

jinja2 commented Jan 11, 2025

Discover mode config test TestDockerObserver is failing

        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -49,3 +49,25 @@
        	            	    (string) (len=26) "receiver_creator/discovery": (map[string]interface {}) (len=2) {
        	            	-    (string) (len=9) "receivers": (map[string]interface {}) (len=2) {
        	            	+    (string) (len=9) "receivers": (map[string]interface {}) (len=3) {
        	            	+     (string) (len=10) "prometheus": (map[string]interface {}) (len=3) {
        	            	+      (string) (len=6) "config": (map[string]interface {}) (len=1) {
        	            	+       (string) (len=6) "config": (map[string]interface {}) (len=1) {
        	            	+        (string) (len=14) "scrape_configs": ([]interface {}) (len=1) {
        	            	+         (map[string]interface {}) (len=5) {
        	            	+          (string) (len=8) "job_name": (string) (len=5) "envoy",
        	            	+          (string) (len=22) "metric_relabel_configs": ([]interface {}) (len=1) {
        	            	+           <max depth reached>
        	            	+          },
        	            	+          (string) (len=12) "metrics_path": (string) (len=17) "/stats/prometheus",
        	            	+          (string) (len=15) "scrape_interval": (string) (len=3) "10s",
        	            	+          (string) (len=14) "static_configs": ([]interface {}) (len=1) {
        	            	+           <max depth reached>
        	            	+          }
        	            	+         }
        	            	+        }
        	            	+       }
        	            	+      },
        	            	+      (string) (len=19) "resource_attributes": (map[string]interface {}) {
        	            	+      },
        	            	+      (string) (len=4) "rule": (string) (len=121) "type == \"container\" and any([name, image, command], {# matches \"(?i)envoy\"}) and not (command matches \"splunk.discovery\")"
        	            	+     },
        	            	      (string) (len=17) "prometheus_simple": (map[string]interface {}) (len=3) {
        	Test:       	TestDockerObserver

@atoulme atoulme force-pushed the add_envoy_metrics branch 2 times, most recently from 92db570 to 0e453a5 Compare January 12, 2025 02:13
@atoulme atoulme merged commit 4fe7405 into main Jan 12, 2025
270 of 272 checks passed
@atoulme atoulme deleted the add_envoy_metrics branch January 12, 2025 05:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants