Network interface for discovery config server #5772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface so we can make assertions with docker services
jinja2
reviewed
Jan 10, 2025
| initialPath = "/debug/configz/initial" | ||
| configServerEnabledEnvVar = "SPLUNK_DEBUG_CONFIG_SERVER" | ||
| configServerPortEnvVar = "SPLUNK_DEBUG_CONFIG_SERVER_PORT" | ||
| configServerNetworkInterfaceEnvVar = "SPLUNK_DEBUG_CONFIG_SERVER_NETWORK_INTERFACE" |
There was a problem hiding this comment.
Should we update the readme/docs to mention this new env var option? I see we have a blurb in our readme about the config server https://github.com/signalfx/splunk-otel-collector/blob/main/README.md?plain=1#L157-L160. We should make a changelog entry also i think
There was a problem hiding this comment.
Right. This deserves more attention than I gave it. I only wanted this for testing purposes.
|
Closing, I got the test to pass by running it in CI and updating the expectations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make it possible to access config server over a different network interface so we can make assertions with docker services.