chef: support .NET zero config on linux #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffreyc-splunk
commented
May 2, 2024
•
jeffreyc-splunk
commented
- Activate .NET auto instrumentation by default if arch is amd64/x86_64 and version >= 0.99.0 for either preload or systemd.
- Update kitchen tests to verify env vars for preload and systemd configs.
jeffreyc-splunk
force-pushed
the
dotnet-zc-chef
branch
2 times, most recently
from
b6ea903 to
eb80a37
Compare
jvoravong
reviewed
May 7, 2024
deployments/chef/CHANGELOG.md
Outdated
| Instrumentation on Linux (x86_64/amd64 only): | ||
| - The .NET SDK is activated by default if the `with_auto_instrumentation` option is set to `true` and | ||
| `auto_instrumentation_version` is `latest` or >= `0.99.0`. | ||
| - Set the `with_auto_instrumentation_sdks` option to `java` and/or `nodejs` to skip .NET auto instrumentation. |
There was a problem hiding this comment.
I might suggest we make points like this more abstract now or later as we will keep adding more supported instrumentation instrumentation languages.
There was a problem hiding this comment.
Something like?
Suggested change
| - Set the `with_auto_instrumentation_sdks` option to `java` and/or `nodejs` to skip .NET auto instrumentation. | |
| - To skip .NET auto instrumentation, configure the `with_auto_instrumentation_sdks` option without `dotnet`. |
jvoravong
reviewed
May 7, 2024
| @@ -5,6 +5,8 @@ | |||
| with_systemd = node['splunk_otel_collector']['auto_instrumentation_systemd'].to_s.downcase == 'true' | |||
| with_java = node['splunk_otel_collector']['with_auto_instrumentation_sdks'].include?('java') | |||
| with_nodejs = node['splunk_otel_collector']['with_auto_instrumentation_sdks'].include?('nodejs') && with_new_instrumentation | |||
| dotnet_supported = %w(x86_64 amd64).include?(node['cpu']['architecture']) && (node['splunk_otel_collector']['auto_instrumentation_version'] == 'latest' || Gem::Version.new(node['splunk_otel_collector']['auto_instrumentation_version']) >= Gem::Version.new('0.99.0')) | |||
There was a problem hiding this comment.
arm support was just added with the recent https://github.com/signalfx/splunk-otel-dotnet/releases/tag/v1.5.0 release. Should we account for this in this PR?
There was a problem hiding this comment.
We'll first need to update and release our splunk-otel-auto-instrumentation deb/rpm packages to include the splunk-otel-dotnet arm64 package before we can add support in our installers.
jeffreyc-splunk
force-pushed
the
dotnet-zc-chef
branch
from
eb80a37 to
d3e41b6
Compare
pjanotti
approved these changes
May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.