-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example configuration for logs on Linux. #3846
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Did you have a plan for this being advertised somewhere (maybe https://github.com/signalfx/splunk-otel-collector#advanced-configuration)? Example configs in this directory aren't necessarily as useful as a dedicated readme section (another case of this was deferred in #3800 (comment)). |
@rmfitzpatrick I'll add a line or two to the README. This confg file is supposed to be useful even with minimum or no editing, so maybe we should drop "example" from its title. |
d29667f
to
81362b5
Compare
include_file_path: true | ||
storage: file_storage/filelogs | ||
|
||
# Apache Cassandra debug log. Contains additional debugging information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we have a very comprehensive config for different Cassandra logs here, do we want to include Garbage collection logs? It is usually written to gc.log
file. It could be used as reference for other jvm services too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed! I will add it in a separate PR.
#- filelog/apache-access | ||
#- filelog/apache-error | ||
#- filelog/cassandra | ||
#- filelog/cassandra-debug | ||
#- filelog/cassandra-output | ||
#- filelog/docker | ||
#- filelog/etcd | ||
#- filelog/jetty9 | ||
#- filelog/jetty9-debug | ||
#- filelog/jetty9-request | ||
#- filelog/mongodb | ||
#- filelog/mysql-error | ||
#- filelog/mysql-query | ||
#- filelog/mysql-slow_query | ||
#- filelog/nginx-access | ||
#- filelog/nginx-error | ||
#- filelog/postgresql | ||
#- filelog/rabbitmq | ||
#- filelog/rabbitmq-startup | ||
#- filelog/rabbitmq-startup_err | ||
#- filelog/redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we comment out all of them? They should be noop if the sources are not available, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no, we get periodic messages (warning level): "finding files: no files match the configured criteria"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's sad. It makes the OOTB experience worse. Do you think that's the right behavior? Maybe worth bringing to the collector community as an issue for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that is an acceptable default behavior -- if you misconfigure the receiver, you get a warning instead of wondering why logs are not coming in. We can propose a new configuration setting for the filelog receiver that controls this.
Adds a new example configuration file for the collector, this one specifically for collecting logs on Linux hosts.