Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example configuration for logs on Linux. #3846

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

bjandras
Copy link
Contributor

Adds a new example configuration file for the collector, this one specifically for collecting logs on Linux hosts.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bjandras
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Oct 26, 2023
@rmfitzpatrick
Copy link
Contributor

Did you have a plan for this being advertised somewhere (maybe https://github.com/signalfx/splunk-otel-collector#advanced-configuration)? Example configs in this directory aren't necessarily as useful as a dedicated readme section (another case of this was deferred in #3800 (comment)).

@bjandras
Copy link
Contributor Author

@rmfitzpatrick I'll add a line or two to the README. This confg file is supposed to be useful even with minimum or no editing, so maybe we should drop "example" from its title.

@bjandras bjandras marked this pull request as ready for review October 27, 2023 17:27
@bjandras bjandras requested review from a team as code owners October 27, 2023 17:27
include_file_path: true
storage: file_storage/filelogs

# Apache Cassandra debug log. Contains additional debugging information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have a very comprehensive config for different Cassandra logs here, do we want to include Garbage collection logs? It is usually written to gc.log file. It could be used as reference for other jvm services too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I will add it in a separate PR.

@bjandras bjandras merged commit a484cf8 into signalfx:main Oct 30, 2023
131 checks passed
@bjandras bjandras deleted the logs_config_linux branch October 30, 2023 16:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
Comment on lines +712 to +732
#- filelog/apache-access
#- filelog/apache-error
#- filelog/cassandra
#- filelog/cassandra-debug
#- filelog/cassandra-output
#- filelog/docker
#- filelog/etcd
#- filelog/jetty9
#- filelog/jetty9-debug
#- filelog/jetty9-request
#- filelog/mongodb
#- filelog/mysql-error
#- filelog/mysql-query
#- filelog/mysql-slow_query
#- filelog/nginx-access
#- filelog/nginx-error
#- filelog/postgresql
#- filelog/rabbitmq
#- filelog/rabbitmq-startup
#- filelog/rabbitmq-startup_err
#- filelog/redis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we comment out all of them? They should be noop if the sources are not available, right?

Copy link
Contributor Author

@bjandras bjandras Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, we get periodic messages (warning level): "finding files: no files match the configured criteria"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's sad. It makes the OOTB experience worse. Do you think that's the right behavior? Maybe worth bringing to the collector community as an issue for discussion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is an acceptable default behavior -- if you misconfigure the receiver, you get a warning instead of wondering why logs are not coming in. We can propose a new configuration setting for the filelog receiver that controls this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants