Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Worfklow coverage to update values.yaml and Chart.yaml dependency versions #852

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

jvoravong
Copy link
Contributor

@jvoravong jvoravong commented Jul 18, 2023

Description

  • Needed to fix an issue with update_instrumentation_dependencies.yaml not getting the latest version numbers properly.
  • Added .github/workflows/update_chart_dependencies.yaml so we could automate updating subchart dependencies.
  • Dependabot makes very similar updates compared to these, but Dependabot does not support updating dependencies like these yet.

Testing

  • Was able to successfully test and validate both workflows in my forked repo.

@jvoravong jvoravong requested review from a team as code owners July 18, 2023 21:18
CHANGELOG.md Outdated Show resolved Hide resolved
@jvoravong
Copy link
Contributor Author

Adding one last fix then merging this PR. Fixing an issue where the release.yaml workflow fires off when the helm chart dependency versions are updated (.github/workflows/update_chart_dependencies.yaml), making it so the release workflow only happens when the chart version is updated.

@jvoravong jvoravong merged commit f76755c into signalfx:main Jul 20, 2023
7 checks passed
@jvoravong jvoravong deleted the OTL-ghwf-expand branch July 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants