Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s.node.name attribute to discovered service entities #1494

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Oct 9, 2024

to fix broken link in the Discovered Services UI

@dmitryax dmitryax requested review from a team as code owners October 9, 2024 05:26
@dmitryax
Copy link
Contributor Author

dmitryax commented Oct 9, 2024

Tests failure is unrelated. Should be fixed by #1495

Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull in the test fix and make sure the tests pass. Otherwise, LGTM.

@dmitryax dmitryax merged commit ee76296 into main Oct 9, 2024
42 checks passed
@dmitryax dmitryax deleted the add-k8s-node-to-entities branch October 9, 2024 18:37
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants