Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the chart - collector agent can use a K8s service by default #1485

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

jvoravong
Copy link
Contributor

Description:
This PR updates the default values.yaml to enable the agent service by default, allowing customers using Kubernetes to send data via a Kubernetes service instead of relying on host ports. This change addresses customer requests for better security and alignment with modern Kubernetes practices, while still maintaining the use of the host network for now.

Changes:

  • Default Change: agent.service.enabled is now set to true to enable the agent service by default.
  • The agent will continue to use the host network as before, ensuring compatibility while we plan future efforts to migrate away from the host network (not in scope for this PR).

@jvoravong jvoravong requested review from a team as code owners October 3, 2024 16:58
@atoulme
Copy link
Contributor

atoulme commented Oct 3, 2024

Is there a CHANGELOG entry to add for this?

@jvoravong
Copy link
Contributor Author

Is there a CHANGELOG entry to add for this?

Changelog entry added.

Just a heads-up: our CI/CD tests for the changelog only check if chart templates were updated and whether a corresponding changelog entry was added. Changes to default values in values.yaml won't trigger the tests.

@jvoravong jvoravong merged commit 35d3cb6 into main Oct 4, 2024
42 checks passed
@jvoravong jvoravong deleted the OTL-3064 branch October 4, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants