Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Background Task Instrumentation #614

Merged
merged 8 commits into from
Aug 25, 2023

Conversation

surbhimaheshwari
Copy link
Contributor

Provides user with an option to disable background process instrumentation using disableBackgroundTaskReporting. If the app is launched using background process, we initialize SplunkRum with No-op instance and thus stop the user from reporting any instrumetnation

@surbhimaheshwari surbhimaheshwari requested review from a team as code owners August 21, 2023 23:10
@surbhimaheshwari surbhimaheshwari changed the title Disable Background Task Instrumentation [Draft] Disable Background Task Instrumentation Aug 21, 2023
@surbhimaheshwari surbhimaheshwari force-pushed the sm/disable_background_task_instrumentation branch 2 times, most recently from 0cddad6 to 8390431 Compare August 21, 2023 23:27
@breedx-splk breedx-splk changed the title [Draft] Disable Background Task Instrumentation Disable Background Task Instrumentation Aug 23, 2023
@breedx-splk breedx-splk marked this pull request as draft August 23, 2023 17:26
@surbhimaheshwari surbhimaheshwari marked this pull request as ready for review August 24, 2023 18:57
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, really just a couple of small suggestions. Thanks!

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@surbhimaheshwari surbhimaheshwari merged commit fdff8fa into main Aug 25, 2023
2 checks passed
@surbhimaheshwari surbhimaheshwari deleted the sm/disable_background_task_instrumentation branch August 25, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants