-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Background Task Instrumentation #614
Merged
surbhimaheshwari
merged 8 commits into
main
from
sm/disable_background_task_instrumentation
Aug 25, 2023
Merged
Disable Background Task Instrumentation #614
surbhimaheshwari
merged 8 commits into
main
from
sm/disable_background_task_instrumentation
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surbhimaheshwari
changed the title
Disable Background Task Instrumentation
[Draft] Disable Background Task Instrumentation
Aug 21, 2023
surbhimaheshwari
force-pushed
the
sm/disable_background_task_instrumentation
branch
2 times, most recently
from
August 21, 2023 23:27
0cddad6
to
8390431
Compare
breedx-splk
changed the title
[Draft] Disable Background Task Instrumentation
Disable Background Task Instrumentation
Aug 23, 2023
breedx-splk
requested changes
Aug 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, really just a couple of small suggestions. Thanks!
splunk-otel-android/src/main/java/com/splunk/rum/BackgroundProcessDetector.java
Outdated
Show resolved
Hide resolved
splunk-otel-android/src/main/java/com/splunk/rum/BackgroundProcessDetector.java
Outdated
Show resolved
Hide resolved
splunk-otel-android/src/main/java/com/splunk/rum/BackgroundProcessDetector.java
Outdated
Show resolved
Hide resolved
splunk-otel-android/src/main/java/com/splunk/rum/SplunkRumBuilder.java
Outdated
Show resolved
Hide resolved
breedx-splk
reviewed
Aug 25, 2023
splunk-otel-android/src/main/java/com/splunk/rum/BackgroundProcessDetector.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
surbhimaheshwari
deleted the
sm/disable_background_task_instrumentation
branch
August 25, 2023 21:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides user with an option to disable background process instrumentation using
disableBackgroundTaskReporting
. If the app is launched using background process, we initialize SplunkRum with No-op instance and thus stop the user from reporting any instrumetnation