Added session.id as key along with rum.session.id for span #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Oof, I had forgotten that the SessionIdSpanAppender is in the upstream package and we will eventually be sourcing it from there. This means that we really shouldn't be making changes in the io.opentelemetry.* packages in this project (they will go away as soon as we can source from an upstream artifact). Sorry for the misleading guidance in the issue.
I think we will need another component that copies from the upstream field name (likely session.id into our rum name). This will need to also be compatible with the LogToSpanBridge sometime soon.
|
Closing it for now until the project is changed to use upstream project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per semantic convention added the replaced the
rum.session.idtosession.id. Adding both of them to the attribute in order to make this backward compatible.Resolves #606