feat: enable watchdog device in firmware by default #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Jan 19, 2025
In siderolabs/pkgs#1134 the driver enabled in the talos kernel. However, this does nothing unless its also enabled in the firmware. I tested with `configTxtAppend: dtparam=watchdog=on` which works. The device is created, and when enabled in talos the watchdog is running. Signed-off-by: Nico Berlee <[email protected]> Signed-off-by: Noel Georgi <[email protected]>
frezbo
force-pushed
the
watchdog-enable
branch
from
8bde9c5 to
e113e8b
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In siderolabs/pkgs#1134 the driver enabled in the talos kernel.
However, this does nothing unless its also enabled in the firmware.
I tested with
configTxtAppend: dtparam=watchdog=onwhich works. The device is created, and when enabled in talos the watchdog is running.related: siderolabs/talos#10099