chore: use kres to manage project #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
commented
Nov 3, 2023
| build: | ||
| - | | ||
| export PKG_CONFIG_PATH=/usr/lib/pkgconfig | ||
|
|
||
| # musl doesn't have glob_onlydir but by spec it's also not guaranteed to return only dirs anyway | ||
| mkdir -p output | ||
|
|
||
| LDFLAGS="$LDFLAGS -L/usr/local/lib" \ |
There was a problem hiding this comment.
the make way of building was already deprecated for iscsi-tools for a while, bringing in gcc 13 broke the build, so switch to meson
smira
approved these changes
Nov 3, 2023
|
do we have reproducibility test as well? |
we never had for extensions, should I add one? |
might be great to have it... less of an issue now, but we should be reproducible? |
Move to using kres to manage project. Signed-off-by: Noel Georgi <[email protected]>
added reproducibility too, |
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to using kres to manage project.