Merge pull request rails#53124 from codergeek121/fix-guide-meta-descr…

…iptions-whitespace Fix prefixed headings in guide pages meta descriptions
siaw23 · Nov 23, 2024 · ce8a6f1 · ce8a6f1
2 parents 31d3cae + ee4f5a9
commit ce8a6f1
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/guides/rails_guides/markdown.rb b/guides/rails_guides/markdown.rb
@@ -23,8 +23,8 @@ def render(body)
       @raw_body = body
       extract_raw_header_and_body
       generate_header
-      generate_description
       generate_title
+      generate_description
       generate_body
       generate_structure
       generate_index
@@ -95,7 +95,7 @@ def generate_header
 
       def generate_description
         sanitizer = Rails::Html::FullSanitizer.new
-        @description = sanitizer.sanitize(@header).squish
+        @description = sanitizer.sanitize(@header).squish.delete_prefix(@heading)
       end
 
       def generate_structure
@@ -174,8 +174,8 @@ def generate_index
       end
 
       def generate_title
-        if heading = html_fragment(@header).at(:h1)
-          @title = "#{heading.text} — Ruby on Rails Guides"
+        if @heading = html_fragment(@header).at(:h1)
+          @title = "#{@heading.text} — Ruby on Rails Guides"
         else
           @title = "Ruby on Rails Guides"
         end