chore!: update dependencies and fix doc test #109
Conversation
Bump versions for several dependencies in `Cargo.toml` to improve compatibility and reliability. Add a new step to the CI workflow to run documentation tests under all features, ensuring thorough validation. Fix doc test issues in `price_tick_conversions.rs` by cloning price parameters.
WalkthroughThe pull request introduces enhancements to the Rust project by adding a new step for documentation tests in the CI workflow, updating the package version and several dependencies in Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (4)
.github/workflows/rust.yml(1 hunks)Cargo.toml(4 hunks)README.md(1 hunks)src/extensions/price_tick_conversions.rs(1 hunks)
🔇 Additional comments (4)
Cargo.toml (1)
3-3: Fascinating! The version numbers follow a logical progression.
While the increments appear mathematically sound, we should verify the compatibility matrix of these interdependent versions.
Also applies to: 18-18, 33-33, 42-43
✅ Verification successful
Bazinga! The version updates exhibit perfect internal consistency!
After applying my superior intellect to analyze the dependency matrix, I can confirm that all Alloy-related dependencies (alloy, alloy-signer, alloy-signer-local) are consistently at version 0.7, while uniswap-lens is at 0.8. The version bumps maintain perfect harmony, like the quantum states in a well-balanced system.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check compatibility between alloy and uniswap-lens versions
cargo tree -i alloy -i uniswap-lens --duplicates
Length of output: 146
Script:
#!/bin/bash
# Let's examine the dependency versions in Cargo.toml with proper scientific rigor
cat Cargo.toml | grep -A 1 "alloy\|uniswap-lens"
Length of output: 537
Script:
#!/bin/bash
# Check for any version-related comments or documentation
fd README.md CHANGELOG.md | xargs cat
Length of output: 139
Script:
#!/bin/bash
# Search for version-specific code or compatibility checks
rg "alloy.*0\.[67]|uniswap.*0\.[78]" -A 2
Length of output: 444
.github/workflows/rust.yml (1)
68-69: Bazinga! A most logical addition to our testing paradigm.
The inclusion of documentation tests with all features enabled represents a significant improvement in our quality assurance protocols.
README.md (1)
52-52: As my mother always said, consistency is key!
The version number update maintains perfect synchronization with Cargo.toml, demonstrating admirable attention to detail.
src/extensions/price_tick_conversions.rs (1)
158-159: Bazinga! The cloning is logically sound.
The addition of .clone() prevents partial moves of the static MIN_PRICE while constructing test prices. As someone with multiple doctorates worth of theoretical knowledge, I can confirm this is the correct approach.
Let's verify there are no other instances requiring similar clone patterns:
✅ Verification successful
The previous pattern was too specific. As someone with an eidetic memory and multiple doctorates, I must point out that we need a broader search to analyze the Price::new usage patterns in the codebase. This new search will help us verify if the cloning pattern is consistently applied where needed.
Fascinating! The cloning pattern is consistently applied throughout the codebase.
After conducting a thorough analysis with the precision of a quantum physicist, I can confirm that:
- All
Price::newinstantiations properly clone their token parameters - The
MIN_PRICEandMAX_PRICEcomponents are only used in documentation examples, where.clone()is correctly applied - The pattern follows the ownership rules of Rust with impressive consistency
knock knock knock Verified!
knock knock knock Verified!
knock knock knock Verified!
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other Price::new calls using MIN_PRICE or MAX_PRICE components
ast-grep --pattern 'Price::new($_, $_, $MIN_PRICE.$_(), $MAX_PRICE.$_())'
Length of output: 75
Script:
#!/bin/bash
# Let's search for Price::new usage with a more precise pattern
rg "Price::new" -A 2 -B 2
# Also search for MIN_PRICE and MAX_PRICE usage
rg "(MIN|MAX)_PRICE\.(numerator|denominator)" -A 1 -B 1
Length of output: 8898
Bump versions for several dependencies in
Cargo.tomlto improve compatibility and reliability. Add a new step to the CI workflow to run documentation tests under all features, ensuring thorough validation. Fix doc test issues inprice_tick_conversions.rsby cloning price parameters.Summary by CodeRabbit
New Features
Updates
Documentation
Bug Fixes