Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify value() to be getter #3

Closed
wants to merge 2 commits into from
Closed

Modify value() to be getter #3

wants to merge 2 commits into from

Conversation

kirosIsK
Copy link
Collaborator

No description provided.

@kirosIsK kirosIsK requested a review from shtse8 March 18, 2024 05:45
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
xdash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 5:47am

@shtse8
Copy link
Owner

shtse8 commented Mar 18, 2024

Thank you for your PR. We appreciate your suggestion to change value() to a getter. However, we use value() as a method intentionally. It signals that calling it does more than just access a property—it processes the value. This distinction is crucial for the library's design, emphasizing that obtaining the value involves computation.

While we value the simplicity of a getter, maintaining value() as a method aligns with our design principles, ensuring users understand the operation's nature.

@shtse8 shtse8 closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants