Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing fixes #1815

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Routing fixes #1815

merged 2 commits into from
Nov 15, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 14, 2024

This PR includes 2 unrelated changes to routing:

  1. prefetch required routing metadata for DeleteRecords and OffsetDelete.
  2. Change RequestSplitAndRouter::get_request_frame to return &mut Self::Request instead of Option<&mut Self::Request>
    • This does not change functionality or fix anything but makes it easier to catch mistakes
    • The caller ignored the value if it was None which made for a very tricky to track down issue due to a typo when implementing KafkaSinkCluster: route DescribeProducers #1814
    • This approach immediately panics if we pass in the wrong type which is good since it indicates an unrecoverable programmer error.

I dont think the performance regression is meaningful.
While it is a kafka benchmark it is purely benching the encoder/decoder which I didnt touch in this PR.

Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #1815 will not alter performance

Comparing rukai:routing_fixes (9c8300a) with main (65ce7cb)

Summary

✅ 38 untouched benchmarks

@rukai rukai marked this pull request as ready for review November 14, 2024 06:20
@rukai rukai enabled auto-merge (squash) November 15, 2024 01:20
@rukai rukai merged commit 819f88c into shotover:main Nov 15, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants