Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 unrelated changes to routing:
DeleteRecords
andOffsetDelete
.RequestSplitAndRouter::get_request_frame
to return&mut Self::Request
instead ofOption<&mut Self::Request>
I dont think the performance regression is meaningful.
While it is a kafka benchmark it is purely benching the encoder/decoder which I didnt touch in this PR.