Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: route *PartitionReassignments #1811

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 13, 2024

This PR adds support for both ListPartitionReassignments and AlterPartitionReassignments.
They are done together because having both makes it easier to write a useful test.
The test looks like:

  1. Create a partition reassignment by calling admin.alterPartitionReassignments
  2. List partition reassignments by calling admin.listPartitionReassignments and then asserting that the created reassignment is listed.

The actual handling of the message types is trivial to implement and just requires routing to a random node.

@rukai rukai changed the title KafkaSinkCluster: route ListPartitionReassignments KafkaSinkCluster: route *PartitionReassignments Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #1811 will not alter performance

Comparing rukai:list_partition_reassignments (d120531) with main (bab7b97)

Summary

✅ 38 untouched benchmarks

@rukai rukai force-pushed the list_partition_reassignments branch 4 times, most recently from 60372aa to 6d7286a Compare November 13, 2024 05:46
@rukai rukai marked this pull request as ready for review November 13, 2024 05:46
@rukai rukai force-pushed the list_partition_reassignments branch from 6d7286a to d120531 Compare November 14, 2024 00:25
@rukai rukai enabled auto-merge (squash) November 14, 2024 00:29
@rukai rukai merged commit 0310cbf into shotover:main Nov 14, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants