Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ins 33065 update docker compose for valkey #1809

Merged
merged 12 commits into from
Nov 13, 2024

Conversation

ronycsdu
Copy link
Collaborator

@ronycsdu ronycsdu commented Nov 13, 2024

Updated the docker_compose files in integration tests to use Valkey instead of redis.

Note: For backward compatibility testing, shotover-proxy/tests/test-configs/redis/passthrough/docker-compose.yaml has not been changed to keep the test that uses library/redis:5.0.9 .

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #1809 will not alter performance

Comparing INS-33065-update-docker-compose-for-valkey (83a76ca) with main (b057491)

Summary

✅ 38 untouched benchmarks

@ronycsdu ronycsdu requested a review from rukai November 13, 2024 01:48
Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just two comments and then we should be good to merge.

Copy link
Member

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@conorbros conorbros merged commit 1d7769e into main Nov 13, 2024
41 checks passed
@conorbros conorbros deleted the INS-33065-update-docker-compose-for-valkey branch November 13, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants