Skip to content

Commit

Permalink
Added launch_at_startup_supported_engines to info.yml to remove hard-…
Browse files Browse the repository at this point in the history
…coded SUPPORTED_ENGINES list from app.
  • Loading branch information
Liam Hoflay authored and Joseph Yu committed Nov 5, 2020
1 parent f303690 commit 7722fb7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
13 changes: 6 additions & 7 deletions app.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,17 @@ def init_app(self):

if self.get_setting("launch_at_startup"):
# show the file manager UI
if self.engine.name in SUPPORTED_ENGINES:
# use a single-shot timer to show the open dialog to allow everything to
# finish being set up first:
from sgtk.platform.qt import QtCore

QtCore.QTimer.singleShot(200, self.show_file_open_dlg)
else:
if SUPPORTED_ENGINES and self.engine.name not in SUPPORTED_ENGINES:
self.log_warning(
"Sorry, the launch at startup option is currently not supported "
"in this engine! You can currently only use it with the following "
"engines: %s" % ", ".join(SUPPORTED_ENGINES)
)
else: # use a single-shot timer to show the open dialog to allow everything to
# finish being set up first:
from sgtk.platform.qt import QtCore

QtCore.QTimer.singleShot(200, self.show_file_open_dlg)

def destroy_app(self):
"""
Expand Down
4 changes: 4 additions & 0 deletions info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,10 @@ requires_engine_version:
# the engines that this app can operate in:
supported_engines:

# the engines that can launch this app on startup
# currently, we have done QA on the following engines:
launch_at_startup_supported_engines: [tk-nuke, tk-maya, tk-3dsmax, tk-katana, tk-katana_foundry] # remove tk-katana_foundry when merged with official release

This comment has been minimized.

Copy link
@Liametc

Liametc Nov 5, 2020

@j0yu you might want to remove tk-katana_foundry as that's specific to us


# the frameworks required to run this app
frameworks:
# We need a version of tk-framework-shotgunutils with a fix for deleting items.
Expand Down

0 comments on commit 7722fb7

Please sign in to comment.