Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve attribute entity article #1561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mitelg
Copy link
Member

@mitelg mitelg commented Nov 15, 2024

No description provided.

@mitelg mitelg force-pushed the chore/improve-attribute-entity-article branch from a2221f2 to 42f8349 Compare November 15, 2024 14:38
use Shopware\Core\Framework\DataAbstractionLayer\EntityCollection;

/**
* @internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would one suggest others, that entity classes are internal. Internal compared to what?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the hint! copy pasta 😅 Will fix it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants