Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize B2B topics & update info for few articles #1041

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Organize B2B topics & update info for few articles #1041

merged 5 commits into from
Oct 25, 2023

Conversation

sushmangupta
Copy link
Collaborator

@sushmangupta sushmangupta commented Aug 4, 2023 •
edited
Loading

  • Rearranging the structure for B2B concepts as discussed in the meeting with @Haberkamp , @LarsKemper , @King-of-Babylon , @Isengo1989 .
  • Create permission via Apps under employee management updated
  • Added "TODO" pointers to include more information from the dev team or respective PO.
  • Added comments to bring clarity to the article
  • Added new content submitted by the dev team

@sushmangupta sushmangupta changed the title Organize B2B topics & update info for few articles WIP: Organize B2B topics & update info for few articles Aug 9, 2023
@sushmangupta sushmangupta added Undocumented Feature Feature which is not documented yet and is considered for documentation DX Team #dev-docs B2B #kung-fu-coders, @st-byte-club labels Aug 9, 2023
@bojanrajh bojanrajh added Blocked Block PRs from merging Manual migration (DevHub) This PR needs to be manually migrated after the DevHub content is migrated labels Sep 8, 2023
King-of-Babylon
King-of-Babylon reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@King-of-Babylon King-of-Babylon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few upper and lower case comments 😊

products/extensions/b2b/README.md Outdated Show resolved Hide resolved
products/extensions/b2b/b2b-components/employee-management/concept/README.md Outdated Show resolved Hide resolved
products/extensions/b2b/b2b-components/employee-management/guides/README.md Outdated Show resolved Hide resolved
products/extensions/b2b/b2b-components/employee-management/guides/b2b-permissions/README.md Outdated Show resolved Hide resolved
products/extensions/b2b/b2b-components/employee-management/guides/b2b-permissions/README.md Outdated Show resolved Hide resolved
products/extensions/b2b/b2b-components/employee-management/guides/b2b-roles.md Outdated Show resolved Hide resolved
@LarsKemper LarsKemper removed the Blocked Block PRs from merging label Sep 22, 2023
@LarsKemper LarsKemper force-pushed the adhoc-1/fix-b2b-component-navi branch 2 times, most recently from c4044ec to 9f8b8c2 Compare September 22, 2023 09:00
@LarsKemper LarsKemper changed the title WIP: Organize B2B topics & update info for few articles Organize B2B topics & update info for few articles Sep 22, 2023
bojanrajh
bojanrajh requested changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@bojanrajh bojanrajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good.

Please, add redirects for all the articles that were moved:

  • products/extensions/b2b-suite/*: products/extensions/b2b/b2b-suite/*
  • ...

@LarsKemper
Copy link
Member

LarsKemper commented Sep 22, 2023 •
edited
Loading

Content looks good.

Please, add redirects for all the articles that were moved:

  • products/extensions/b2b-suite/*: products/extensions/b2b/b2b-suite/*
  • ...

For me, the redirects doesn't work at all. Even the existing ones are redirecting me to the 404 page
For example:
guides/integrations-api/store-api-guide/handling-the-payment: guides/integrations-api/README.md
When I open : https://developer.shopware.com/docs/guides/integrations-api/store-api-guide/handling-the-payment it redirects to the 404.

@Isengo1989
Copy link
Collaborator

Isengo1989 commented Sep 27, 2023 •
edited
Loading

@LarsKemper I guess there was still old code/urls from gitbook, since we moved recently to devhub there was a change in the URL path endings, @bojanrajh fixed this recently.

732c446

Those redirects work now. Could you take another look? If you need help, let me know (but you probably know better what was moved. If you pass me a list, I can look into it as well)

@King-of-Babylon
Copy link
Contributor

@LarsKemper I guess there was still old code/urls from gitbook, since we moved recently to devhub there was a change in the URL path endings, @bojanrajh fixed this recently.

732c446

Those redirects work now. Could you take another look? If you need help, let me know (but you probably know better what was moved. If you pass me a list, I can look into it as well)

Hi @Isengo1989,

I guess the redirects should look like that:

  • products/extensions/b2b-components/employee-management/concept/index.md: products/extensions/b2b/b2b-components/employee-management/concept/README.md

  • products/extensions/b2b-components/employee-management/guides/creating-own-permissions-via-app.md: products/extensions/b2b/b2b-components/employee-management/guides/b2b-permissions/creating-own-permissions-via-app.md

  • products/extensions/b2b-components/employee-management/guides/index.md: products/extensions/b2b/b2b-components/employee-management/guides/README.md

  • products/extensions/b2b-components/employee-management/index.md: products/extensions/b2b/b2b-components/employee-management/README.md

  • products/extensions/b2b-components/index.md: products/extensions/b2b/b2b-components/README.md

  • products/extensions/b2b-suite/guides/administration/index.md: products/extensions/b2b/b2b-suite/guides/administration/README.md

@Isengo1989 Isengo1989 force-pushed the adhoc-1/fix-b2b-component-navi branch from 9f8b8c2 to 744c2ec Compare October 13, 2023 14:06
@Isengo1989
Copy link
Collaborator

@bojanrajh I rebased it and adjusted the mentioned topics. Please check the redirects (question about wildcards - slack)

@Isengo1989 Isengo1989 force-pushed the adhoc-1/fix-b2b-component-navi branch from f3dd666 to fca64fd Compare October 17, 2023 11:55
@Isengo1989 Isengo1989 merged commit e52aa61 into main Oct 25, 2023
2 checks passed
@Isengo1989 Isengo1989 deleted the adhoc-1/fix-b2b-component-navi branch October 25, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haberkamp Haberkamp Haberkamp left review comments

@LarsKemper LarsKemper LarsKemper approved these changes

@King-of-Babylon King-of-Babylon King-of-Babylon approved these changes

@bojanrajh bojanrajh Awaiting requested review from bojanrajh

Assignees

@bojanrajh bojanrajh

Labels
B2B #kung-fu-coders, @st-byte-club DX Team #dev-docs Manual migration (DevHub) This PR needs to be manually migrated after the DevHub content is migrated Undocumented Feature Feature which is not documented yet and is considered for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sushmangupta @LarsKemper @Isengo1989 @King-of-Babylon @Haberkamp @bojanrajh