feat: added customer vault token route #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianKe
force-pushed
the
feat/vault-token-route
branch
2 times, most recently
from
04062a5 to
b63f694
Compare
FlorianKe
force-pushed
the
feat/vault-token-route
branch
from
b63f694 to
9db3f02
Compare
cyl3x
reviewed
Jan 30, 2025
FlorianKe
force-pushed
the
feat/vault-token-route
branch
2 times, most recently
from
5928db6 to
6466754
Compare
FlorianKe
force-pushed
the
feat/vault-token-route
branch
from
6466754 to
3655fae
Compare
mstegmeyer
requested changes
Feb 1, 2025
Comment on lines
+65
to
+72
| return new JsonResponse( | ||
| ['token' => $this->tokenResource->getUserIdToken($context->getSalesChannelId(), $vault->getTokenCustomer())->getIdToken()] | ||
| ); | ||
| } | ||
|
|
||
| return new JsonResponse( | ||
| ['token' => $this->tokenResource->getUserIdToken($context->getSalesChannelId())->getIdToken()] | ||
| ); |
There was a problem hiding this comment.
I would suggest this to be a TokenResponse instead of a generic JsonResponse. This would also make things easier in the StorefrontDataServices, not having to decode json again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://shopware.atlassian.net/browse/PPI-1044