22: add timeline feature #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shockbytes
force-pushed
the
22-add-timeline-feature
branch
from
ad650a6 to
d2d7321
Compare
lockieRichter
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Not part of your change, but can you add translations for the add_label_bottom_sheet entries at line 9?
| ), | ||
| body: LayoutBuilder( | ||
| builder: (context, constraints) { | ||
| return StreamBuilder<List<TimelineMonthGrouping>>( |
There was a problem hiding this comment.
We can avoid using things like StreamBuilders and FutureBuilders using riverpod. What you want to do is create a provider like so
@riverpod
Stream<List<TimelineMonthGrouping>> getTimelineData(GetTimelineDataRef ref) =>
ref.watch(timelineProvider).getTimelineData();then in the wifget builder you can do a ref.watch(getTimelineDataProvider) and usewhen to get the loading, data and error states. This leads to cleaner code IMO and is what I've been doing for most of our components.
Check out the add_label_bottom_sheet file and the getBookLabels provider for an exmaple of this.
You don't have to make this change, but it will stay consistent with the rest of our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added the timeline page. (and added a
LottieView, which will make it easier for us to add lottie animations throughout the codebase)The timeline page will adapt to smaller devices and will show smaller book images on phones.
I came up with a simplified UI version of the timeline, as I think it's more appropriate and a bigger book image is preferrable to the title of the book. Most people will recognize book images before looking at the book title. Furthermore, you can still click on the books, if you are really unsure about the book.
Screenshots
Desktop View
Empty View Mobile