Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement book label logic #82

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

lockieRichter
Copy link
Collaborator

Implements the book label logic for the book detail page.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-11-06.at.16.42.09.mp4

@lockieRichter lockieRichter self-assigned this Nov 6, 2023
@lockieRichter
Copy link
Collaborator Author

This doesn't work on web, but that's because the Book Detail page doesn't work on web. Can fix that in the next MR.

build.yaml Show resolved Hide resolved
@lockieRichter
Copy link
Collaborator Author

All comments addressed

Copy link
Owner

@shockbytes shockbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can't wait to get this merged because then I can finally finish the Realm migration stuff.

@lockieRichter lockieRichter merged commit 4b6a56c into develop Nov 9, 2023
@lockieRichter lockieRichter deleted the implement-book-label branch November 9, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants