Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change position using drag and drop #101

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Change position using drag and drop #101

merged 1 commit into from
Mar 3, 2024

Conversation

lockieRichter
Copy link
Collaborator

@lockieRichter lockieRichter commented Mar 2, 2024 •
edited
Loading

Also fixes broken google sign in.

@lockieRichter lockieRichter requested a review from shockbytes March 2, 2024 04:19
@lockieRichter lockieRichter self-assigned this Mar 2, 2024
@lockieRichter lockieRichter force-pushed the 70-change-the-position-of-books-within-the-state-via-dragdrop branch from a631e12 to 74bebd1 Compare March 2, 2024 05:17
@lockieRichter
Copy link
Collaborator Author

lockieRichter commented Mar 2, 2024 •
edited
Loading

Not sure why web build is failing in GitHub actions, web seems to be building fine for me locally

@lockieRichter lockieRichter force-pushed the 70-change-the-position-of-books-within-the-state-via-dragdrop branch from 74bebd1 to 69ca8fe Compare March 2, 2024 10:48
@lockieRichter
Copy link
Collaborator Author

Also, @shockbytes is the idea to implement this for Web too?

shockbytes
shockbytes approved these changes Mar 3, 2024
View reviewed changes
lib/src/providers/authentication.dart Outdated
Comment on lines 51 to 52
// clientId:
// '150599422814-moto7djse1tf7vtso7slemniki76ohg6.apps.googleusercontent.com',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, sorry meant to delete this. All our google sign in stuff should be handled now in the install of the package, so we don't need to actually specify this here (see https://pub.dev/packages/google_sign_in_ios#ios-integration)

@shockbytes
Copy link
Owner

@lockieRichter I approved it.

It does not need to be implemented on Web for the moment.

The build breaks. You need to update the dependency web to version >= 0.4.2 to make it build.

@lockieRichter
Copy link
Collaborator Author

No worries @shockbytes, to fix this issue I've had to bump the minimum Dart version in pubspec to 3.3.0, to be able to support this you'll need to use the latest flutter 3.19.2

@lockieRichter lockieRichter force-pushed the 70-change-the-position-of-books-within-the-state-via-dragdrop branch from 69ca8fe to 894fa78 Compare March 3, 2024 22:32
@lockieRichter lockieRichter merged commit 6520b13 into develop Mar 3, 2024
3 checks passed
@lockieRichter lockieRichter deleted the 70-change-the-position-of-books-within-the-state-via-dragdrop branch March 3, 2024 22:34
@lockieRichter lockieRichter linked an issue Mar 4, 2024 that may be closed by this pull request
Change the position of books within the state via drag/drop #70
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shockbytes shockbytes shockbytes approved these changes

Assignees

@lockieRichter lockieRichter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the position of books within the state via drag/drop
2 participants
@lockieRichter @shockbytes