-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tgrs #30
Open
psmithshine
wants to merge
30
commits into
master
Choose a base branch
from
upgrade-tgrs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade tgrs #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update tsconfig target and packages in shared - update packages in server
- upgrade server packages necessary to support Node v20, and remove some deprecated packages - adopt new Apollo Server API from Apollo v4.9 (jumped two major versions), for much of the setup of the local standalone server - use latest tsconfig for Node v20 - use more sensical Datasources sertup (to also complement newer Apollo API)
…n cli package version
👍 Node v20 Upgrades 👍 - update package versions to support latest node - use same GraphQL codegen tooling as Server for consistent code generation across BE/FE, + with codegen.yaml file ⚡️ Vite Upgrades ⚡️ - new Vite build + dev server tool - the speed!! 🚀 - supporting Vite packages, vite config, index.html setup, index.html placement, tsconfig setup, start and build scripts updates - remove react-scripts and any react scripts setup 🤮
…an yarn - update node for nodenv tool
… the correct server EP, so we're getting error on requesting from server
I have pushed some commits to this branch to get the integration environment and tests running properly again, and get the auth directive in-place again. Note that I have removed the client and server tests because they weren't passing with your changes, and they're not really something I use on client sites anyway (I mostly rely on integration tests). |
bent
requested changes
Jul 8, 2024
- use the generated `graphql` function, rather than `gql`, so we get free typings from codegend code without needing to explicitly specify them
…n import paths accordingly - remove codegen script
…ns/aws-lambda package` - also remove associated comment from index.ts module
bent
reviewed
Jul 10, 2024
…into upgrade-tgrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
client
,server
,shared
, andintegration
packages and support and run Node v20. Local development and build is faster 🚀 and the overall app's runtime (Node) is no longer deprecated!! 🔒Changelog
Server - Node v20 🔥
Upgrade Apollo + GraphQL packages to their latest versions to be compatible with Node v20. Other packages such as
concurrently
andtsx
are there to support running the server locally in Node v20 context. Significant re-writes for the server were necessary as the API for Apollo has changed over the major version bumps and changes. The Datasources was re-written to better complement the setup for the Server. Thetsconfig
updates allows for the Server to read the new module syntax whichshared
package compiles, and brings it into the more modern Typescript era.Client - Lets get Vite ⚡️
Now using ViteJS build tool as a replacement of react-scripts for compiling and running the app locally, as well as building it for production. The react team doesn't even recommend using their own react-scripts tool anymore, and the community much prefer Vite over react-scripts - so it was time! You will find that Vite is significantly quicker to run localhost and to build the app.
index.html uses the new Vite-friendly syntax, like ridding the %PUBLIC_URL% stuff for project-relative paths
adding a vite.config.ts, for a basic Vite build configuration to work with our React app
package.json had the following updates:
type: module
for Vite to functiontsconfig
to also have updated compilerOptions -> specifically having module and target be ES6.Integration 🔀 - A bit incomplete!
The integration package was difficult to get working, and for now "works".. It has been crippled as I could not work out how to get tests working with the Stubby function and relied on some hardcoding. Insight from @bent would be greatly appreciated!