Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "error: no viable conversion" #167

Merged
merged 1 commit into from
May 3, 2024

Conversation

xiota
Copy link

@xiota xiota commented May 3, 2024

Fixes #165.

Typo in e763a70 causes following error:

dolphin-emu-primehack/Source/Core/InputCommon/XInput2Mouse.cpp:36:25: error: no viable conversion from 'XInput2Mouse' to 'pointer' (aka 'prime::GenericMouse *')
   36 |     g_mouse_input.reset(XInput2Mouse((Window)hwnd, xi_opcode, current_master->deviceid));
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.2.1/../../../../include/c++/13.2.1/bits/unique_ptr.h:505:21: note: passing argument to parameter '__p' here
  505 |       reset(pointer __p = pointer()) noexcept
      |                     ^
1 error generated.

@SirMangler SirMangler merged commit 26beef4 into shiiion:primehack-master May 3, 2024
1 check passed
@SirMangler
Copy link
Collaborator

Good catch, thanks!

@xiota xiota deleted the pr_fix branch May 3, 2024 10:28
SirMangler pushed a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation error on Linux: "no viable conversion"
2 participants