Ensure tooltips stay on screen & doesn't get in the way #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the tooltip is wider than half the screen width, it often ends up partially off-screen. Let's ensure the tooltip always wraps to less than `screen.width / 2`. Additionally, lets render the tooltip above the cursor, instead of in-line with it. This allows the user to more easily read what they're hovering over without the tooltip getting in the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tooltip is wider than half the screen width, it often ends up partially off-screen.
This PR fixes that by ensuring the tooltip always wraps to less than
screen.width / 2.Additionally, it shifts the tooltip above the cursor, instead of in-line with it. This allows the user to more easily read what they're hovering over without the tooltip getting in the way. Especially multi-line tooltips.
FYI the upcoming 1.19.4 release "Changed how tooltips in the menu UI are positioned so buttons are still readable" in Snapshot 23w05a, so the
mouseY - heighttooltip shift may be redundant or duplicated once that's released.