Ensure table names are unique and preset #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayonj
force-pushed
the
s/shadow-table
branch
from
ba825d5
to
995cd26
Compare
jfrost
requested changes
Feb 15, 2022
| # Set this early on to ensure their creation and cleanup (unexpected) | ||
| # happens at all times. IOW, the calls from Store.get always return | ||
| # the same value. | ||
| Store.set(:old_primary_table, "pgosc_op_table_#{client.table}") |
There was a problem hiding this comment.
We should make sure to set the maximum length of these table names to 63. In fact, all identifiers in postgresql are limited to NAMEDATALEN - 1 or 63.
There was a problem hiding this comment.
yep def! Since we change the sequence name too (so its unique between primary and shadow table), keeping it short is nice.
Just to future proof, i added a spec. They are between 20/21 char len.
Since we are not restoring index/sequence name for now, ensuring the table names are unique so that if we run the same operation on the same table, there is no sequence conflict. The sequence will get overriden on the table anyways, but won't fail and complain when trying to create a shadow before the swap. This is temporary until we support restoring original index and sequence names. Can be a pro feature too
shayonj
force-pushed
the
s/shadow-table
branch
from
995cd26
to
0ae325f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not restoring index/sequence name for now,
ensuring the table names are unique so that if we run the same
operation on the same table, there is no sequence conflict. The sequence
will get overriden on the table anyways, but won't fail and complain
when trying to create a shadow before the swap. This is temporary until
we support restoring original index and sequence names(#20). Can be a pro feature too