Update readme, fix rare bug #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgiesinger
commented
Jan 24, 2020
adamgiesinger
commented
- Fixed a bug that sometimes prevented the user from authenticating
- Updated the README to match FIFA 20 parameters
nicklog
reviewed
Jan 24, 2020
| @@ -131,7 +131,7 @@ public function login(?string $code = null) : array | |||
| 'release_type' => 'prod', | |||
| 'redirect_uri' => 'https://www.easports.com/fifa/ultimate-team/web-app/auth.html', | |||
| // 'redirect_uri' => 'nucleus:rest', | |||
| 'scope' => 'basic.identity offline signin basic.entitlement', | |||
| //'scope' => 'basic.identity offline signin basic.entitlement', | |||
There was a problem hiding this comment.
Did you verify this by debugging the website?
At my last check this field was required.
There was a problem hiding this comment.
I didn't debug the website but this resolved the issues I had on my MacBook while not breaking anything on my PC. Let me know if this doesn't work for you!
There was a problem hiding this comment.
I would appreciate it if you would check this in the Chrome or Firefox debugger. Thank you very much.
lippl
suggested changes
May 3, 2020
| use FUTApi\Api\Authentication\Account; | ||
| use FUTApi\Api\Authentication\Credentials; | ||
| use FUTApi\Api\Authentication\Session; | ||
| use FShapecode\FUT\Client\Api\Core; |
There was a problem hiding this comment.
isn't this a typo? changeuse FShapecode\FUT\Client\Api\Core; to use Shapecode\FUT\Client\Api\Core;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.