fix: nodered health check + compose env var interpolation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container health-check script for node-red relies on the `settings.js` to exist in the `/data/settings.js` directory in the container. Refactor by mounting the file as readonly into the container. fixes #100 Signed-off-by: Shantanoo 'Shan' Desai <[email protected]>
Due to consolidating the InfluxDBv1/v2 related env vars into `.env` the playbook generates a Compose file with no values set for any environment variables that need to be interpolated via the `.env` file. In order to mitigate this, the compose validation + generation tasks do not interpolate the env vars and remove path resolution too. With this fix, the files generated can then rely on `.env` file even if the file generated after validation. fixes #102 Signed-off-by: Shantanoo 'Shan' Desai <[email protected]>
shantanoo-desai
added
node-red
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary