Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby Dependencies #1595

Merged
merged 13 commits into from
Jan 10, 2024
Merged

Update Ruby Dependencies #1595

merged 13 commits into from
Jan 10, 2024

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Jan 8, 2024

This change is Reviewable

@ahangarha ahangarha force-pushed the update-dependencies branch from 1833503 to 270507e Compare January 8, 2024 14:43
@ahangarha ahangarha force-pushed the update-dependencies branch from 25ae017 to bbb41bf Compare January 8, 2024 15:50
@ahangarha ahangarha force-pushed the update-dependencies branch from 784ab96 to 891bf53 Compare January 8, 2024 16:44
@ahangarha ahangarha force-pushed the update-dependencies branch from 891bf53 to d7ec85e Compare January 8, 2024 16:46
@ahangarha ahangarha changed the title WIP - Update dependencies UpdateRuby Dependencies Jan 8, 2024
@ahangarha ahangarha changed the title UpdateRuby Dependencies Update Ruby Dependencies Jan 8, 2024
@ahangarha ahangarha requested a review from Judahmeek January 8, 2024 17:29
@ahangarha ahangarha marked this pull request as ready for review January 8, 2024 17:29
@@ -3,7 +3,7 @@ version: 2

aliases:
- &docker-image
- image: circleci/ruby:2.7-node-browsers
- image: circleci/ruby:3.0-node-browsers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 3.0 the newest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use circleci for ROR at all?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but good to have the example file.

gem "bootsnap", require: false
gem "rails", "~> 7.0", ">= 7.0.1"
gem "rails", "~> 7.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any updates needed for the Rails upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice anything to apply to this project.

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justin808 justin808 merged commit 2c04db6 into master Jan 10, 2024
19 of 20 checks passed
@justin808 justin808 deleted the update-dependencies branch January 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants