-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to react_on_rails 14.1.0.rc.0 #612
Conversation
WalkthroughThe pull request involves a targeted update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Hi 👋 To deploy a review app, please comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Gemfile (1)
8-9
: Document the pre-release version usageConsider adding a comment explaining why we're using a release candidate version and any specific features or fixes needed from this version.
-gem "react_on_rails", "14.1.0.rc.0" +# TODO: Using RC version for testing. Remove comment when stable version is released +gem "react_on_rails", "14.1.0.rc.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Gemfile.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
Gemfile
(1 hunks)
🔇 Additional comments (1)
Gemfile (1)
8-9
: Verify shakapacker compatibilityThe fixed version of shakapacker (8.0.0) needs to be verified for compatibility with react_on_rails 14.1.0.rc.0.
✅ Verification successful
Let me check the shakapacker configuration file to understand the setup better.
Let me check the react_on_rails configuration file for any version-specific settings.
Shakapacker 8.0.0 is compatible with react_on_rails 14.1.0.rc.0
Based on the verification:
- The shakapacker configuration is properly set up with the necessary integration points for react_on_rails
- The project is using React 18.2.0, which is supported by both shakapacker 8.0.0 and react_on_rails 14.1.0.rc.0
- The react_on_rails configuration is properly configured to work with shakapacker, as evidenced by the build commands using
bin/shakapacker
- The shakapacker configuration includes the necessary development and production settings that align with react_on_rails requirements
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check shakapacker's package.json for peer dependencies fd -t f "package.json" | xargs cat | jq '.dependencies["shakapacker"], .dependencies["@rails/webpacker"]' # Look for any version-specific configuration fd -t f "webpacker.yml|shakapacker.yml"Length of output: 183
Script:
#!/bin/bash # Check shakapacker configuration cat config/shakapacker.yml # Let's also check if there are any specific react_on_rails configuration files fd -t f "react_on_rails.rb" # Search for any version-specific settings or configurations rg -i "shakapacker.*version|webpacker.*version|react.*version" -g '!{node_modules,tmp,log}/*'Length of output: 1938
Script:
#!/bin/bash # Check react_on_rails configuration cat config/initializers/react_on_rails.rb # Let's also check package.json for React version and other dependencies fd -t f "package.json" | xargs cat | jq '.dependencies["react"], .dependencies["react-dom"], .peerDependencies'Length of output: 3843
test updating react_on_rails to latest release
This change is
Summary by CodeRabbit
react_on_rails
gem to version 14.1.0.rc.0