feat: Support for XOne devices #7529
Draft
+35
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still testing it |
avelad
added
type: enhancement
|
Incremental code coverage: 81.82% |
joeyparrish
reviewed
Oct 31, 2024
joeyparrish
reviewed
Nov 1, 2024
| */ | ||
| static isXOne() { | ||
| let rdk = false; | ||
| if (window && Object.keys(window).includes('ServiceManager')) { |
There was a problem hiding this comment.
Does this simpler version work instead?
if (window.ServiceManager && window.ServiceManager.getServiceForJavaScript &&
navigator.platform.includes('Linux aarch64') &&
shaka.util.Platform.userAgentContains_('AppleWebKit') &&
shaka.util.Platform.userAgentContains_('Version/8.0')) {You will need to add a file following the example of externs/xbox.js to satisfy the compiler that ServiceManager and getServiceForJavaScript might exist. The types can be very simple if you don't need to call into any of that functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #7522