Skip to content

Commit

Permalink
fix(shaka-lab-node): Do not require optional parameters (#51)
Browse files Browse the repository at this point in the history
In #50, I forgot to mark all the newly-added parameters as optional, which broke some nodes in the lab.
  • Loading branch information
joeyparrish authored May 8, 2024
1 parent 8ba9ba8 commit 9da6f53
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions shaka-lab-node/node-templates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ chromecast:
params:
- hostname
- version
- receiver-app-id
- idle-timeout-seconds
- ?receiver-app-id # optional
- ?idle-timeout-seconds # optional
defs:
genericwebdriver.browser.name: chromecast
genericwebdriver.backend.exe: node_modules/.bin/chromecast-webdriver-server$cmd
Expand All @@ -77,10 +77,10 @@ chromeos:
params:
- hostname
- version
- username
- private-key
- fetch-private-key
- private-key-url
- ?username # optional
- ?private-key # optional
- ?fetch-private-key # optional
- ?private-key-url # optional
defs:
genericwebdriver.browser.name: chromeos
genericwebdriver.backend.exe: node_modules/.bin/chromeos-webdriver-server$cmd
Expand All @@ -100,10 +100,10 @@ tizen:
- hostname
- ?ethaddr # optional
- version
- local-tizen-studio
- tizen-studio-docker-image
- tizen-studio-path
- tizen-studio-author-profile
- ?local-tizen-studio # optional
- ?tizen-studio-docker-image # optional
- ?tizen-studio-path # optional
- ?tizen-studio-author-profile # optional
defs:
genericwebdriver.browser.name: tizen
genericwebdriver.backend.exe: node_modules/.bin/tizen-webdriver-server$cmd
Expand Down

0 comments on commit 9da6f53

Please sign in to comment.