fix: Application crash on some platforms

[agajassi]

Corrects application crash issue described in See issue/75 by excluding encryptionScheme field from some older platforms.

[avelad]

@agajassi Why not disable polyfill installation in Shaka Player directly for these platforms? (https://github.com/shaka-project/shaka-player/blob/main/lib/polyfill/encryption_scheme.js#L26)

[agajassi]

@agajassi Why not disable polyfill installation in Shaka Player directly for these platforms? (https://github.com/shaka-project/shaka-player/blob/main/lib/polyfill/encryption_scheme.js#L26)

It did not even occur to me to disable it from shaka player. I guess I was under the impression that these platforms need that polyfil as well. I can give it a try and run some tests. Let me do that first

[joeyparrish]

If I understand correctly, it's crashing when you feed encryptionScheme into MediaKeys?

[joeyparrish]

It did not even occur to me to disable it from shaka player. I guess I was under the impression that these platforms need that polyfil as well.

They don't "need" it, but if Shaka wants to filter content by encryption scheme, and encryption scheme support is not native and not polyfilled, Shaka may try to play some things that can't be played. The platform may decrypt with the right keys and the wrong scheme, feeding garbage data to the decoder.

[agajassi]

If I understand correctly, it's crashing when you feed encryptionScheme into MediaKeys?

That is correct

[agajassi]

They don't "need" it, but if Shaka wants to filter content by encryption scheme, and encryption scheme support is not native and not polyfilled, Shaka may try to play some things that can't be played. The platform may decrypt with the right keys and the wrong scheme, feeding garbage data to the decoder

@joeyparrish I understand what you're saying, and I agree. It makes more sense to skip the polyfill for these platforms. If in the future these platforms start supporting encryptionScheme, we can easily re-enable it.

Thank you both. 👍🏼 I will close this pr and instead open one in shaka player itself.

[agajassi]

Closing this pr. This will be handled in the player repo