Improve sceSystemServiceReceiveEvent stub #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily based on fpPS4's stubbed implementation. Until the various GetEvent functions in libSceSystemService and libSceUserService are implemented, this is all this function needs.
|
Sorry, Ghost of Tsushima uses this |
|
Now GoTs goes further |
|
@gandalfthewhite19890404 Could you provide a log? I've got the method set to log some extra details, so a log will tell me if there's anything the game is hardcoded to expect. |
|
Thanks, looks like my stub is working as expected in Ghost of Tsushima. |
|
Stranger of Paradise: Final Fantasy Origin also uses it and it now goes in-game graphic |
polybiusproxy
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added both an EventType enum, and what should be the proper event struct, both based primarily off fpPS4 implementations. In the one game I've seen calling this function, the game runs a while loop until ReceiveEvent returns something other than 0, causing an infinite loop with the current implementation.
This needs testing with other games that can call this function, as I would assume some games may regress from the error return. If any regressions are found, please provide a log.
Confirmed improvements: