input: Don't use old input state in GameController::ReadState() #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Main: main.mp4PR: pr.mp4 |
ngoquang2708
force-pushed
the
fix-input-lag
branch
2 times, most recently
from
0e707a1 to
13f2b17
Compare
|
it seems you accidentally committed the |
ngoquang2708
force-pushed
the
fix-input-lag
branch
from
13f2b17 to
fba15bd
Compare
Nice catch. Thanks. |
|
Can someone check Gravity Rush Remastered with this PR? |
|
hmm i would prefer no SDL code in controller.cpp since it gonna be generic (as i imagine it at least) and have devices for inputs (SDL_keyboard ,SDL_Gamepad , XInput etc) |
|
Hoped this would fix Disgaea 5 but nope 2025-01-17.10-16-09.mp4 |
ngoquang2708
force-pushed
the
fix-input-lag
branch
from
fba15bd to
9ed083d
Compare
|
Ended up refactor the whole input subsystem. |
ngoquang2708
force-pushed
the
fix-input-lag
branch
from
9ed083d to
263d06d
Compare
ngoquang2708
force-pushed
the
fix-input-lag
branch
3 times, most recently
from
726f239 to
de2b9bc
Compare
Fix input lag when there is multiple user inputs happen at the same time. SDL input events can only fire one at a time and game may get some input events later than other.
ngoquang2708
force-pushed
the
fix-input-lag
branch
from
de2b9bc to
f85ab38
Compare
Confirmed motion controls is still working. |
|
This could also fix Minecraft input lag |
Could you test it? |
ngoquang2708
commented
Jan 18, 2025
roamic
approved these changes
Jan 18, 2025
diegolix29
added a commit
to diegolix29/shadPS4
that referenced
this pull request
Jan 18, 2025
…() (shadps4-emu#2170)" This reverts commit 90b04e8.
diegolix29
added a commit
to diegolix29/shadPS4
that referenced
this pull request
Jan 18, 2025
…() (shadps4-emu#2170)" This reverts commit 90b04e8.
kalaposfos13
added a commit
to kalaposfos13/shadPS4
that referenced
this pull request
Jan 18, 2025
…() (shadps4-emu#2170)" This reverts commit 90b04e8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix input lag when there is multiple user inputs happen at the same time. SDL input events can only fire one at a time and game may get some input events later than other.