core/libraries: Videodec2 implementation #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polybiusproxy
force-pushed
the
core/vdec2
branch
from
bc9849b to
c85122f
Compare
|
@vladmikhalin can you review this? |
It's still a draft, is it ready for review? |
|
it is ready |
It's still marked as a draft but I'd still want you to review it |
roamic
reviewed
Oct 10, 2024
|
what other games uses videcodec2 expect persona???? |
|
Rock Band 4 and lots of Unreal Engine games, it seems |
polybiusproxy
changed the title
polybiusproxy
force-pushed
the
core/vdec2
branch
from
c85122f to
3dc4857
Compare
polybiusproxy
force-pushed
the
core/vdec2
branch
3 times, most recently
from
db0e695 to
0bbf917
Compare
|
I believe this is ready to merge. The remaining tasks can be left for later. |
roamic
reviewed
Oct 18, 2024
polybiusproxy
force-pushed
the
core/vdec2
branch
2 times, most recently
from
6c20d9f to
8751b76
Compare
polybiusproxy
force-pushed
the
core/vdec2
branch
from
8751b76 to
4c1ae8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-in-progress implementation of the Videodec2 library, used for AVC (H.264) and HEVC (H.265) video decoding.
Seen on games such as Persona 5 Royal and Rock Band 4.
Left tasks:
The memory querying functions are quite important, as the sizes we output can affect games - for example, if we give a low size for memory querying on Persona 5 Royal, the decode output breaks (see the first image below).
The decoder library outputs a different size depending on the decoder profile given by the game.