fix(shadcn): fixes form error color to use text-destructive-foreground

[petalas]

What does this PR do?

• Changes the color for errors in forms to use text-destructive-foreground instead of text-destructive

Preview

Before:

After:

Explanation:

If I understand correctly, generally:

• --destructive is for the background color of destructive components
• --destructive-foreground is for the text / foreground elements of destructive components

Testing with catppuccin mocha colors

@layer base {
  .dark {
    --background: 240 21% 15%;
    --foreground: 226 64% 88%;
    --destructive: 240 23% 9%;
    --destructive-foreground: 343 81% 75%;
  }
}

Here is how a toast looks with these colors as a sanity check.

Hopefully this makes sense, let me know if I'm misunderstanding something, new to shadcn.

[vercel]

@petalas is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.