-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Router] Implement router backbone #1695
Conversation
cd2ba91
to
44f22ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will revert once review is done. this is for fast ci iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been disabled
|
||
data_path = "test.jsonl" | ||
|
||
if is_local() is True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
python3 test_moe_eval_accuracy_large.py | ||
|
||
- name: Evaluate MLA Accuracy (TP=2) | ||
- name: Evaluate DP Router Accuracy (DP = 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our discussion offline, we would like to go with rust. Should we still merge this?
Due to the low performance of 2-level HTTP with python server, i will try to re-implement in rust. Closing the issue for now! |
Motivation
The first step of #1732. See full context in the design doc
This PR implements:
Modifications
router/
folder under srtUsage
Tests
TODO
/health_generate
etc)Checklist