Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Deduct TX fees #442

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Fix: Deduct TX fees #442

merged 2 commits into from
Nov 5, 2024

Conversation

scorpioborn
Copy link
Contributor

@scorpioborn scorpioborn commented Nov 4, 2024 •
edited
Loading

Description

Fix partial deduction of transaction fees.

Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation

Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@scorpioborn scorpioborn marked this pull request as ready for review November 4, 2024 17:30
@scorpioborn scorpioborn requested a review from a team as a code owner November 4, 2024 17:30
@scorpioborn scorpioborn merged commit b1ced16 into sge-network:master Nov 5, 2024
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-U-D-G-E P-U-D-G-E P-U-D-G-E approved these changes

Assignees
No one assigned
Labels
C:app-wiring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scorpioborn @P-U-D-G-E